Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refresh IntelliSense time#3680

Merged
andreeis merged 7 commits into
mastermicrosoft/vscode-cpptools:masterfrom
dev/andris/flamemicrosoft/vscode-cpptools:dev/andris/flameCopy head branch name to clipboard
May 22, 2019
Merged

Refresh IntelliSense time#3680
andreeis merged 7 commits into
mastermicrosoft/vscode-cpptools:masterfrom
dev/andris/flamemicrosoft/vscode-cpptools:dev/andris/flameCopy head branch name to clipboard

Conversation

@andreeis

@andreeis andreeis commented May 22, 2019

Copy link
Copy Markdown
Contributor

Small change to add timing information about how long it takes for IntelliSense to refresh.

@andreeis andreeis requested review from a team and bobbrow May 22, 2019 18:03
@pieandcakes

Copy link
Copy Markdown
Contributor

@andreeis Please run the tslinter to fix the failed builds.

@pieandcakes

pieandcakes commented May 22, 2019

Copy link
Copy Markdown
Contributor

Is this feature to to show users the time the flame is on? Should we be logging this to telemetry too(if we aren't doing it) so we can see what the trend is?

I don't know if Flame on should be the term for this as it has other connotations. @tara-raj Do you have a better term for this?

@andreeis

andreeis commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

Small change to add timing information about how long it takes for IntelliSense to refresh.

@andreeis andreeis changed the title Flame on timing IntelliSense flame active time May 22, 2019
Comment thread Extension/src/LanguageServer/client.ts Outdated
@andreeis andreeis changed the title IntelliSense flame active time Refresh IntelliSense time May 22, 2019
@andreeis

Copy link
Copy Markdown
Contributor Author

Is this feature to show users the time the flame is on? Should we be logging this to telemetry too(if we aren't doing it) so we can see what the trend is?

Currently we don't collect this information as telemetry. So far, this change is useful only for visual mapping of a particular timing value with the coding operation done in VSCode. We are thinking whether is worth to collect the same info via telemetry and what is the best way to do that (aggregation criterias, more info about the operation associated with a particular timing value).

@andreeis andreeis requested a review from bobbrow May 22, 2019 18:54
Comment thread Extension/src/LanguageServer/client.ts
@andreeis andreeis merged commit 627acc5 into master May 22, 2019
@andreeis andreeis deleted the dev/andris/flame branch May 22, 2019 21:03
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.