Add a command to rescan the workspace#3658
Merged
bobbrow merged 11 commits intoJun 5, 2019
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/rescanFoldermicrosoft/vscode-cpptools:bobbrow/rescanFolderCopy head branch name to clipboard
Merged
Add a command to rescan the workspace#3658bobbrow merged 11 commits intomastermicrosoft/vscode-cpptools:masterfrom bobbrow/rescanFoldermicrosoft/vscode-cpptools:bobbrow/rescanFolderCopy head branch name to clipboard
bobbrow merged 11 commits into
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/rescanFoldermicrosoft/vscode-cpptools:bobbrow/rescanFolderCopy head branch name to clipboard
Conversation
Contributor
|
rescan folder seems fine, since the command is just for a single workspace folder and not the entire workspace. |
bobbrow
commented
May 16, 2019
Colengms
approved these changes
May 16, 2019
…scode-cpptools into bobbrow/rescanFolder
xisui-MSFT
reviewed
May 30, 2019
sean-mcmanus
requested changes
Jun 5, 2019
sean-mcmanus
left a comment
Contributor
There was a problem hiding this comment.
The commands should all "title cased" to match the other VS Code command styles.
Some of our existing commands had the incorrect "sentence" casing and no one noticed.
sean-mcmanus
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/vscode-cpptools-api#11.
Should we call it "rescan folder" or "rescan workspace"?