Fix ${workspaceFolderBasename} resolving to "untitled", and add ${workspaceStorage}#3643
Merged
sean-mcmanus merged 8 commits intoMay 21, 2019
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/workspaceFolderBasenameFixmicrosoft/vscode-cpptools:seanmcm/workspaceFolderBasenameFixCopy head branch name to clipboard
Merged
Fix ${workspaceFolderBasename} resolving to "untitled", and add ${workspaceStorage}#3643sean-mcmanus merged 8 commits intomastermicrosoft/vscode-cpptools:masterfrom seanmcm/workspaceFolderBasenameFixmicrosoft/vscode-cpptools:seanmcm/workspaceFolderBasenameFixCopy head branch name to clipboard
sean-mcmanus merged 8 commits into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/workspaceFolderBasenameFixmicrosoft/vscode-cpptools:seanmcm/workspaceFolderBasenameFixCopy head branch name to clipboard
Conversation
pieandcakes
suggested changes
May 14, 2019
pieandcakes
reviewed
May 14, 2019
bobbrow
requested changes
May 17, 2019
…om/Microsoft/vscode-cpptools into seanmcm/workspaceFolderBasenameFix
bobbrow
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for an issue reported at #3642 .