Address issue with trailing backslashes in config path not squiggled#3573
Merged
Colengms merged 10 commits intoMay 1, 2019
mastermicrosoft/vscode-cpptools:masterfrom
coleng/trailingQuoteBugmicrosoft/vscode-cpptools:coleng/trailingQuoteBugCopy head branch name to clipboard
Merged
Address issue with trailing backslashes in config path not squiggled#3573Colengms merged 10 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/trailingQuoteBugmicrosoft/vscode-cpptools:coleng/trailingQuoteBugCopy head branch name to clipboard
Colengms merged 10 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/trailingQuoteBugmicrosoft/vscode-cpptools:coleng/trailingQuoteBugCopy head branch name to clipboard
Conversation
bobbrow
reviewed
May 1, 2019
| let newResults: string = ""; | ||
| let lastWasBackslash: Boolean = false; | ||
| let lastBackslashWasEscaped: Boolean = false; | ||
| for (let i: number = 0; i < readResults.length; i++) { |
Member
There was a problem hiding this comment.
Can you factor this out into a separate function, and then add some unit tests for it?
Contributor
There was a problem hiding this comment.
Can that go in a future pull request? We want to ship this fix today.
sean-mcmanus
approved these changes
May 1, 2019
…into coleng/trailingQuoteBug
…t/vscode-cpptools into coleng/trailingQuoteBug
…into coleng/trailingQuoteBug
…t/vscode-cpptools into coleng/trailingQuoteBug
sean-mcmanus
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior approach using a RegEx was identifying a backslash followed by a quote as an escaped quote, even if that backslash was itself escaped. Unclear how to solve that with RegEx. Replaced with manual parsing.