Various settings UI load/save related changes#3529
Merged
Colengms merged 2 commits intoApr 25, 2019
mastermicrosoft/vscode-cpptools:masterfrom
coleng/pathEscaping2microsoft/vscode-cpptools:coleng/pathEscaping2Copy head branch name to clipboard
Merged
Various settings UI load/save related changes#3529Colengms merged 2 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/pathEscaping2microsoft/vscode-cpptools:coleng/pathEscaping2Copy head branch name to clipboard
Colengms merged 2 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/pathEscaping2microsoft/vscode-cpptools:coleng/pathEscaping2Copy head branch name to clipboard
Conversation
michelleangela
suggested changes
Apr 24, 2019
| private configDirty: boolean = false; | ||
| private settingsPanelViewStateChanged = new vscode.EventEmitter<ViewStateEvent>(); | ||
| private settingsPanelActivated = new vscode.EventEmitter<void>(); | ||
| private settingsPanelStateChanged = new vscode.EventEmitter<void>(); |
Contributor
There was a problem hiding this comment.
Rename to onConfigValuesChanged?
Contributor
Author
There was a problem hiding this comment.
configValuesChanged? (the other event is not using 'on') Or, use 'on' for both?
Contributor
|
Also, add this pull request to our internal "pending change log" list under bug fixes. |
sean-mcmanus
approved these changes
Apr 25, 2019
Member
|
Since this feature is not yet released in an official channel, any changelog updates would only apply to a future insiders release. It wouldn't need to go in the changelog for 0.23.0. |
michelleangela
approved these changes
Apr 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated parsePropertiesFileAndHandleSquiggles into parsePropertiesFile(true).
Switched from delayed saving to saving immediately as setting change, using a new event.
Removed some escaping logic from parsePropertiesFile(false) not needed for settings UI.
Changed SettingsPanelViewStateChanged to SettingsPanelActivated, only triggered on activation.
Removed previous fix slash escaping fix.