Update Select Configurations command to offer Edit Configs JSON option#3519
Merged
Colengms merged 3 commits intoApr 24, 2019
mastermicrosoft/vscode-cpptools:masterfrom
coleng/SelectConfigurationEditUseJsonmicrosoft/vscode-cpptools:coleng/SelectConfigurationEditUseJsonCopy head branch name to clipboard
Merged
Update Select Configurations command to offer Edit Configs JSON option#3519Colengms merged 3 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/SelectConfigurationEditUseJsonmicrosoft/vscode-cpptools:coleng/SelectConfigurationEditUseJsonCopy head branch name to clipboard
Colengms merged 3 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/SelectConfigurationEditUseJsonmicrosoft/vscode-cpptools:coleng/SelectConfigurationEditUseJsonCopy head branch name to clipboard
Conversation
bobbrow
requested changes
Apr 24, 2019
bobbrow
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Select Configuration..." command will display a list of configurations to choose between, or an option to "Edit Configurations...".
Settings UI uses this Select Configurations command to allow the user to change which configuration is currently being edited.
Because the user is likely to select the option to edit configurations when the configuration they want to select is not on the list, and because settings UI does not yet allow new configurations to be added, we should offer "Edit Configurations (JSON)" in the selection list instead.