Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding support for .env files for cppvsdbg#3500

Merged
WardenGnaw merged 3 commits into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/vsdbgEnvFileWardenGnaw/vscode-cpptools:dev/waan/vsdbgEnvFileCopy head branch name to clipboard
Apr 26, 2019
Merged

Adding support for .env files for cppvsdbg#3500
WardenGnaw merged 3 commits into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/vsdbgEnvFileWardenGnaw/vscode-cpptools:dev/waan/vsdbgEnvFileCopy head branch name to clipboard

Conversation

@WardenGnaw

Copy link
Copy Markdown
Member

This PR allows users to have a .env file that listed as
KEY=VALUE or KEY="VALUE WITH SPACE" to be used as environment variables
when launching a process. Anything that begins with '#' is treated as a
comment. Blank lines are ignored.

This .env file will be used if envFile passed in with the launch.json.
It will also work with the existing environment variable, however
anything listed in the .env file will overwrite anything from the
environment field in the launch.json.

@gregg-miskelly

@WardenGnaw WardenGnaw requested review from a team and pieandcakes April 20, 2019 00:55
@WardenGnaw WardenGnaw self-assigned this Apr 20, 2019
@WardenGnaw

Copy link
Copy Markdown
Member Author

Addresses #3490

@michelleangela

Copy link
Copy Markdown
Contributor

Is this targeting 0.23.0-insiders?

Comment thread Extension/package-lock.json Outdated
@WardenGnaw

Copy link
Copy Markdown
Member Author

@michelleangela there’s no big rush for this PR

Comment thread Extension/package.json Outdated
@sean-mcmanus

Copy link
Copy Markdown
Contributor

@WardenGnaw Can you check this in by our 0.23.0-insiders2 on Friday? We want the next Insiders to be as close to the final release as possible.

This PR allows users to have a .env file that listed as
KEY=VALUE or KEY="VALUE WITH SPACE" to be used as environment variables
when launching a process. Anything that begins with '#' is treated as a
comment. Blank lines are ignored.

This .env file will be used if envFile passed in with the launch.json.
It will also work with the existing environment variable, however
anything listed in the .env file will overwrite anything from the
environment field in the launch.json.
@WardenGnaw WardenGnaw force-pushed the dev/waan/vsdbgEnvFile branch from 2487bee to 826ba4c Compare April 26, 2019 21:44
@WardenGnaw WardenGnaw merged commit 6a88c99 into microsoft:master Apr 26, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.