Add use of queryTranslationUnitSource to determine if custom configuration can be skipped#3393
Merged
Colengms merged 6 commits intoApr 3, 2019
mastermicrosoft/vscode-cpptools:masterfrom
dev/coleng/QueryTranslationUnitSourceRequestmicrosoft/vscode-cpptools:dev/coleng/QueryTranslationUnitSourceRequestCopy head branch name to clipboard
Merged
Add use of queryTranslationUnitSource to determine if custom configuration can be skipped#3393Colengms merged 6 commits intomastermicrosoft/vscode-cpptools:masterfrom dev/coleng/QueryTranslationUnitSourceRequestmicrosoft/vscode-cpptools:dev/coleng/QueryTranslationUnitSourceRequestCopy head branch name to clipboard
Colengms merged 6 commits into
mastermicrosoft/vscode-cpptools:masterfrom
dev/coleng/QueryTranslationUnitSourceRequestmicrosoft/vscode-cpptools:dev/coleng/QueryTranslationUnitSourceRequestCopy head branch name to clipboard
Conversation
Member
bobbrow
requested changes
Apr 2, 2019
bobbrow
approved these changes
Apr 3, 2019
bobbrow
left a comment
Member
There was a problem hiding this comment.
We should wait until the language server change is ready before we commit this, but this change is basically ready to go.
| } | ||
|
|
||
| public async provideCustomConfiguration(document: vscode.TextDocument): Promise<void> { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add call in provideCustomConfiguration to new QueryTranslationUnitSourceRequest. If a system header or there is already a TU loaded, skip custom configuration.