Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix error when rootRui is null.#2614

Merged
sean-mcmanus merged 1 commit into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/fixRootUriNullRefmicrosoft/vscode-cpptools:seanmcm/fixRootUriNullRefCopy head branch name to clipboard
Oct 5, 2018
Merged

Fix error when rootRui is null.#2614
sean-mcmanus merged 1 commit into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/fixRootUriNullRefmicrosoft/vscode-cpptools:seanmcm/fixRootUriNullRefCopy head branch name to clipboard

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

Fix for #2613 .

@grdowns grdowns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had always thought it was strange that strings are default initialized to "undefined". I suppose it's an optimization of some kind for type comparison, but man does it lead to some painful bugs.

@sean-mcmanus sean-mcmanus merged commit e819f36 into master Oct 5, 2018
@bobbrow bobbrow deleted the seanmcm/fixRootUriNullRef branch October 8, 2018 17:51
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.