Grdowns/update channel4#2576
Merged
bobbrow merged 9 commits intoOct 2, 2018
mastermicrosoft/vscode-cpptools:masterfrom
grdowns/update-channel4microsoft/vscode-cpptools:grdowns/update-channel4Copy head branch name to clipboard
Merged
Grdowns/update channel4#2576bobbrow merged 9 commits intomastermicrosoft/vscode-cpptools:masterfrom grdowns/update-channel4microsoft/vscode-cpptools:grdowns/update-channel4Copy head branch name to clipboard
bobbrow merged 9 commits into
mastermicrosoft/vscode-cpptools:masterfrom
grdowns/update-channel4microsoft/vscode-cpptools:grdowns/update-channel4Copy head branch name to clipboard
Conversation
bobbrow
requested changes
Sep 28, 2018
| } | ||
|
|
||
| function isRateLimit(input: any): input is RateLimit { | ||
| return input && input.rate && isRate(input.rate); |
Member
There was a problem hiding this comment.
nit: checking input.rate here should be unnecessary (isRate will do it)
| } | ||
|
|
||
| function isRate(input: any): input is Rate { | ||
| return input && input.remaining && typeof(input.remaining) === 'number'; |
Member
There was a problem hiding this comment.
I think Sean added a util.isNumber function.
|
|
||
| async function rateLimitExceeded(): Promise<boolean> { | ||
| const rateLimit: RateLimit = await getRateLimit(); | ||
| if (rateLimit.rate.remaining <= 0) { |
Member
There was a problem hiding this comment.
this is an async function using await. You should be able to just return rateLimit.rate.remaining here.
…into grdowns/update-channel4
bobbrow
requested changes
Oct 1, 2018
| } | ||
|
|
||
| async function getRateLimit(): Promise<RateLimit> { | ||
| const header: OutgoingHttpHeaders = { 'User-Agent': 'vscode-cpptools' }; |
Member
There was a problem hiding this comment.
it looks like this is double-indented
bobbrow
approved these changes
Oct 1, 2018
Member
|
TSlint: |
bobbrow
approved these changes
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant telemetry on failure
Check GitHub API rate limit prior to attempting to download release
Update error message for failing to parse release JSON into type Build[]