Add ab testing for Go to Def (fix some ab testing bugs)#2559
Merged
bobbrow merged 5 commits intoSep 26, 2018
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/abTestGoToDefmicrosoft/vscode-cpptools:seanmcm/abTestGoToDefCopy head branch name to clipboard
Merged
Add ab testing for Go to Def (fix some ab testing bugs)#2559bobbrow merged 5 commits intomastermicrosoft/vscode-cpptools:masterfrom seanmcm/abTestGoToDefmicrosoft/vscode-cpptools:seanmcm/abTestGoToDefCopy head branch name to clipboard
bobbrow merged 5 commits into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/abTestGoToDefmicrosoft/vscode-cpptools:seanmcm/abTestGoToDefCopy head branch name to clipboard
Conversation
bobbrow
approved these changes
Sep 25, 2018
| }, | ||
| vcpkg_root: util.getVcpkgRoot() | ||
| vcpkg_root: util.getVcpkgRoot(), | ||
| goto_def_intelliSense: abTestSettings.UseGoToDefIntelliSense |
Member
There was a problem hiding this comment.
please rename to gotoDefIntelliSense or similar.
| return this.state.get<T>(this.key, this.defaultvalue); | ||
| } | ||
|
|
||
| public get DefaultValue(): T { |
Member
There was a problem hiding this comment.
nit: Can you move this under the setter for Value to keep the two properties together?
| }, | ||
| vcpkg_root: util.getVcpkgRoot() | ||
| vcpkg_root: util.getVcpkgRoot(), | ||
| goto_def_intelliSense: abTestSettings.UseGoToDefIntelliSense |
Member
There was a problem hiding this comment.
Doing this in init works for now, but I'd imagine that at some point in the future we'll want a separate abTestingSettingsChanged message or something similar in the future. That will allow us to make the settings read async again too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.