Allow telemetry to detect failed downloads#2332
Merged
WardenGnaw merged 1 commit intoJul 26, 2018
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/fixDownloadTelemetryWardenGnaw/vscode-cpptools:dev/waan/fixDownloadTelemetryCopy head branch name to clipboard
Merged
Allow telemetry to detect failed downloads#2332WardenGnaw merged 1 commit intomicrosoft:mastermicrosoft/vscode-cpptools:masterfrom WardenGnaw:dev/waan/fixDownloadTelemetryWardenGnaw/vscode-cpptools:dev/waan/fixDownloadTelemetryCopy head branch name to clipboard
WardenGnaw merged 1 commit into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/fixDownloadTelemetryWardenGnaw/vscode-cpptools:dev/waan/fixDownloadTelemetryCopy head branch name to clipboard
Conversation
bobbrow
approved these changes
Jul 26, 2018
bobbrow
left a comment
Member
There was a problem hiding this comment.
This should work. The "false" data we have appears to only be logged when an exception is thrown during the installation process. Since the download code doesn't throw, we weren't getting the telemetry in the place I expected. Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.