Seanmcm/windows sdk version#2241
Merged
sean-mcmanus merged 6 commits intoJul 10, 2018
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/windowsSDKVersionmicrosoft/vscode-cpptools:seanmcm/windowsSDKVersionCopy head branch name to clipboard
Merged
Seanmcm/windows sdk version#2241sean-mcmanus merged 6 commits intomastermicrosoft/vscode-cpptools:masterfrom seanmcm/windowsSDKVersionmicrosoft/vscode-cpptools:seanmcm/windowsSDKVersionCopy head branch name to clipboard
sean-mcmanus merged 6 commits into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/windowsSDKVersionmicrosoft/vscode-cpptools:seanmcm/windowsSDKVersionCopy head branch name to clipboard
Conversation
bobbrow
requested changes
Jul 8, 2018
| "description": "The value to use in a configuration if \"macFrameworkPath\" is not specified, or the values to insert if \"${default}\" is present in \"macFrameworkPath\".", | ||
| "scope": "resource" | ||
| }, | ||
| "C_Cpp.default.windowsSDKVersion": { |
Member
There was a problem hiding this comment.
SDK should be Sdk per convention
Contributor
Author
There was a problem hiding this comment.
Ah, okay -- that's easier to read :)
bobbrow
reviewed
Jul 9, 2018
| }, | ||
| "windowsSDKVersion": { | ||
| "description": "Version of the Windows SDK include path to use on Windows, e.g. '10.0.17134.0'.", | ||
| "type": "string" |
Member
There was a problem hiding this comment.
should probably add patternProperties (reference) to this so we can get squiggles for invalid versions. (see the env property).
The regexp is this, I think: ^\d{2}\.\d{1}\.\d{5}\.\d{1}$
bobbrow
approved these changes
Jul 10, 2018
| "windowsSdkVersion": { | ||
| "description": "Version of the Windows SDK include path to use on Windows, e.g. '10.0.17134.0'.", | ||
| "type": "string", | ||
| "pattern": "^\\d{2}\\.\\d{1}\\.\\d{5}\\.\\d{1}$|^8.1$" |
Member
There was a problem hiding this comment.
The 8.1 part should have a backslash before the dot
| ], | ||
| "default": null, | ||
| "description": "Version of the Windows SDK include path to use on Windows, e.g. '10.0.17134.0'.", | ||
| "scope": "resource" |
Member
There was a problem hiding this comment.
Should the pattern go in here too?
Contributor
Author
There was a problem hiding this comment.
Hmm...it doesn't seem to be required...I could try adding it...oh, this is the default one...I didn't test that yet...
…oft/vscode-cpptools into seanmcm/windowsSDKVersion
bobbrow
approved these changes
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still reviewing/testing this some more, so you could wait a while if you want...