start sending installation failure telemetry again#2189
Merged
bobbrow merged 1 commit intoJun 26, 2018
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/failureTelemetrymicrosoft/vscode-cpptools:bobbrow/failureTelemetryCopy head branch name to clipboard
Merged
start sending installation failure telemetry again#2189bobbrow merged 1 commit intomastermicrosoft/vscode-cpptools:masterfrom bobbrow/failureTelemetrymicrosoft/vscode-cpptools:bobbrow/failureTelemetryCopy head branch name to clipboard
bobbrow merged 1 commit into
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/failureTelemetrymicrosoft/vscode-cpptools:bobbrow/failureTelemetryCopy head branch name to clipboard
Conversation
bobbrow
commented
Jun 26, 2018
| retryCount += 1; | ||
| lastError = error; | ||
| if (retryCount >= MAX_RETRIES) { | ||
| if (retryCount > MAX_RETRIES) { |
Member
Author
There was a problem hiding this comment.
we used to do 5 retries, but currently are only doing 4 because of retryCount + 1 before this check
sean-mcmanus
approved these changes
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed in 0.15.0.