Polishing the custom configuration provider experience#2188
Merged
bobbrow merged 28 commits intoJun 26, 2018
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/customConfigUImicrosoft/vscode-cpptools:bobbrow/customConfigUICopy head branch name to clipboard
Merged
Polishing the custom configuration provider experience#2188bobbrow merged 28 commits intomastermicrosoft/vscode-cpptools:masterfrom bobbrow/customConfigUImicrosoft/vscode-cpptools:bobbrow/customConfigUICopy head branch name to clipboard
bobbrow merged 28 commits into
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/customConfigUImicrosoft/vscode-cpptools:bobbrow/customConfigUICopy head branch name to clipboard
Conversation
| }); | ||
|
|
||
| test("Check provider", async () => { | ||
| // Open a c++ file to start the language server. |
Contributor
There was a problem hiding this comment.
I think c++ should be C++.
| standard: "c++17" | ||
| }; | ||
|
|
||
| // has to be 'any' instead of api.CustomConfigurationProvider because dispose is missing on the old interface version |
Contributor
There was a problem hiding this comment.
Seems like it should be formatted as a sentence (like the other sentence comments), e.g. // Has … .
| if (version !== Version.v0 && !provider.dispose) { | ||
| missing.push("'dispose'"); | ||
| } | ||
| console.error(`CustomConfigurationProvider was not registered. The following properties are missing from the implementation: ${missing.join(", ")}`); |
Contributor
There was a problem hiding this comment.
Should there be a period at the end of the error message?
| constructor(provider: CustomConfigurationProvider, version: Version) { | ||
| this.provider = provider; | ||
| if (provider.extensionId && version === Version.v0) { | ||
| version = Version.v1; // provider implemented the new API but is interfacing with the extension using the old API version. |
Contributor
There was a problem hiding this comment.
Capital "Provider". Also, what's up with multiple spaces before //? Can we stick to 1 space? I haven't seen multiple spaces before // used anywhere else.
| public onRegisterCustomConfigurationProvider(provider: CustomConfigurationProvider1): Thenable<void> { | ||
| return this.notifyWhenReady(() => { | ||
| if (!this.RootPath) { | ||
| return; // There is no folder open, therefore there is no c_cpp_properties.json to edit. |
Contributor
There was a problem hiding this comment.
Comma should be a ; or new sentence. See http://www.grammar-monster.com/lessons/semicolons_before_transitional_phrases.htm .
sean-mcmanus
approved these changes
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.