Bobbrow/recursive includes#2136
Merged
bobbrow merged 4 commits intoJun 15, 2018
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/recursiveIncludesmicrosoft/vscode-cpptools:bobbrow/recursiveIncludesCopy head branch name to clipboard
Merged
Bobbrow/recursive includes#2136bobbrow merged 4 commits intomastermicrosoft/vscode-cpptools:masterfrom bobbrow/recursiveIncludesmicrosoft/vscode-cpptools:bobbrow/recursiveIncludesCopy head branch name to clipboard
bobbrow merged 4 commits into
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/recursiveIncludesmicrosoft/vscode-cpptools:bobbrow/recursiveIncludesCopy head branch name to clipboard
Conversation
bobbrow
commented
Jun 15, 2018
| @@ -1,3 +1,5 @@ | ||
| { | ||
| "intelliSenseEngine_default_percentage": 100 | ||
| "intelliSenseEngine_default_percentage": 100, |
Member
Author
There was a problem hiding this comment.
keeping the old one around unless we want to create a new fwlink url
bobbrow
commented
Jun 15, 2018
| const cpptoolsJsonFile: string = util.getExtensionFilePath(localConfigFile); | ||
|
|
||
| try { | ||
| const exists: boolean = await util.checkFileExists(cpptoolsJsonFile); |
Member
Author
There was a problem hiding this comment.
not sure we need to check the file exists since we're in a try/catch already...
sean-mcmanus
approved these changes
Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still waiting for the updated json file to upload, but this code can be reviewed now