make browse.path optional#2135
Merged
bobbrow merged 1 commit intoJun 15, 2018
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/optionalBrowsePathmicrosoft/vscode-cpptools:bobbrow/optionalBrowsePathCopy head branch name to clipboard
Merged
make browse.path optional#2135bobbrow merged 1 commit intomastermicrosoft/vscode-cpptools:masterfrom bobbrow/optionalBrowsePathmicrosoft/vscode-cpptools:bobbrow/optionalBrowsePathCopy head branch name to clipboard
bobbrow merged 1 commit into
mastermicrosoft/vscode-cpptools:masterfrom
bobbrow/optionalBrowsePathmicrosoft/vscode-cpptools:bobbrow/optionalBrowsePathCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Jun 15, 2018
| // If the user doesn't set browse.path, copy the includePath over. Make sure ${workspaceFolder} is in there though... | ||
| configuration.browse.path = configuration.includePath.slice(0); | ||
| if (-1 === configuration.includePath.findIndex((value: string, index: number) => { | ||
| return !!value.match(/^\$\{(workspaceRoot|workspaceFolder)\}(\\|\\\*\*|\/|\/\*\*)?$/g); |
Contributor
There was a problem hiding this comment.
Oh, value.match return null if it's not found, so !null == true, and !true is false...maybe using != null would be less confusing?
Member
Author
There was a problem hiding this comment.
i didn't want to check for empty array vs null vs undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.