Merged
Conversation
bobbrow
commented
May 11, 2018
| // WARNING: The default limit on Linux is 8k, so for big directories, this can cause file watching to fail. | ||
| this.rootPathFileWatcher = vscode.workspace.createFileSystemWatcher( | ||
| path.join(this.RootPath, "*"), | ||
| "**/*", |
Member
Author
There was a problem hiding this comment.
note that we don't get file delete notifications for every file in a deleted folder, so we'll need to update the language server to take care of that specially.
sean-mcmanus
approved these changes
May 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something must have changed in VS Code with the file watcher API because we stopped getting file created/deleted events. This change fixes it.