Merged
update release notes and don't enable recursive includes by default in new folders#1948
Conversation
sean-mcmanus
approved these changes
May 7, 2018
WardenGnaw
approved these changes
May 7, 2018
| if (!settings.defaultIncludePath) { | ||
| // We don't add system includes to the includePath anymore. The language server has this information. | ||
| configuration.includePath = ["${workspaceFolder}/**"].concat(this.vcpkgIncludes); | ||
| configuration.includePath = ["${workspaceFolder}"].concat(this.vcpkgIncludes); |
Member
There was a problem hiding this comment.
nit: this.vcpkgIncludes.unshift("${workspaceFolder}")
Member
Author
There was a problem hiding this comment.
My understanding is that unshift modifies the source array and returns the length instead of a new array. This is not what we want here.
Member
There was a problem hiding this comment.
Whoops, I thought we were adding to this.vspkgIncludes. Nevermind!
sean-mcmanus
approved these changes
May 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.