Adding OptionsSchema generation#1937
Merged
WardenGnaw merged 3 commits intoMay 4, 2018
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/generateOptionsSchemaWardenGnaw/vscode-cpptools:dev/waan/generateOptionsSchemaCopy head branch name to clipboard
Merged
Adding OptionsSchema generation#1937WardenGnaw merged 3 commits intomicrosoft:mastermicrosoft/vscode-cpptools:masterfrom WardenGnaw:dev/waan/generateOptionsSchemaWardenGnaw/vscode-cpptools:dev/waan/generateOptionsSchemaCopy head branch name to clipboard
WardenGnaw merged 3 commits into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/generateOptionsSchemaWardenGnaw/vscode-cpptools:dev/waan/generateOptionsSchemaCopy head branch name to clipboard
Conversation
This is to prevent repetitive fields from being copy and pasted improperly.
bobbrow
reviewed
May 4, 2018
| return objects; | ||
| } | ||
|
|
||
| function mergeReferences(baseDefinitions: any, additionalDefinitions: any) : void { |
Member
There was a problem hiding this comment.
inconsistent capitalization of functions. We generally follow the JavaScript conventions of camelCasing for functions in the extension, but I know there are some places where PascalCasing has been used. Maybe we need a tslint rule for that.
Member
Author
There was a problem hiding this comment.
There not one in the core ruleset. palantir/tslint#2277
There is a package that does it: https://www.npmjs.com/package/vrsource-tslint-rules#ext-variable-name
I'll add this as its own PR since it might affect a lot of things. And since its a dev-dependency, we dont need to update third party licenses text?
bobbrow
approved these changes
May 4, 2018
sean-mcmanus
approved these changes
May 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to prevent repetitive fields from being copy and pasted
improperly.
There are some parts of OptionsSchema.json that needs to be fixed. E.g. logging for cppvsdbg.