Boolean default types should be boolean not string#1732
Merged
WardenGnaw merged 1 commit intoMar 23, 2018
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/fixBoolDefaultsWardenGnaw/vscode-cpptools:dev/waan/fixBoolDefaultsCopy head branch name to clipboard
Merged
Boolean default types should be boolean not string#1732WardenGnaw merged 1 commit intomicrosoft:mastermicrosoft/vscode-cpptools:masterfrom WardenGnaw:dev/waan/fixBoolDefaultsWardenGnaw/vscode-cpptools:dev/waan/fixBoolDefaultsCopy head branch name to clipboard
WardenGnaw merged 1 commit into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
WardenGnaw:dev/waan/fixBoolDefaultsWardenGnaw/vscode-cpptools:dev/waan/fixBoolDefaultsCopy head branch name to clipboard
Conversation
pieandcakes
approved these changes
Mar 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #737
The type is boolean, but the default value is wrong.