Add intermediary type to safely construct vscode.Ranges for use#1492
Merged
grdowns merged 4 commits intoJan 26, 2018
mastermicrosoft/vscode-cpptools:masterfrom
inactive-region-highlightmicrosoft/vscode-cpptools:inactive-region-highlightCopy head branch name to clipboard
Merged
Add intermediary type to safely construct vscode.Ranges for use#1492grdowns merged 4 commits intomastermicrosoft/vscode-cpptools:masterfrom inactive-region-highlightmicrosoft/vscode-cpptools:inactive-region-highlightCopy head branch name to clipboard
grdowns merged 4 commits into
mastermicrosoft/vscode-cpptools:masterfrom
inactive-region-highlightmicrosoft/vscode-cpptools:inactive-region-highlightCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Jan 26, 2018
bobbrow
reviewed
Jan 26, 2018
| } | ||
|
|
||
| interface InputRange { | ||
| start: { line: number, character: number }; |
Member
There was a problem hiding this comment.
, [](start = 25, length = 1)
nit: should be a semi-colon. (surprised the linter didn't pick this up)
Contributor
Author
There was a problem hiding this comment.
Noted for the future!
…oft/vscode-cpptools into inactive-region-highlight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.