Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

IntelliSense string updates.#13580

Merged
sean-mcmanus merged 6 commits into
mainmicrosoft/vscode-cpptools:mainfrom
seanmcm/may1_intellisense_stringsmicrosoft/vscode-cpptools:seanmcm/may1_intellisense_stringsCopy head branch name to clipboard
May 4, 2025
Merged

IntelliSense string updates.#13580
sean-mcmanus merged 6 commits into
mainmicrosoft/vscode-cpptools:mainfrom
seanmcm/may1_intellisense_stringsmicrosoft/vscode-cpptools:seanmcm/may1_intellisense_stringsCopy head branch name to clipboard

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented May 1, 2025

Copy link
Copy Markdown
Contributor

Translations are pending in a week or so.

@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools May 1, 2025
bobbrow
bobbrow previously approved these changes May 1, 2025
@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 1, 2025 23:40
@sean-mcmanus sean-mcmanus requested a review from a team as a code owner May 1, 2025 23:40
@sean-mcmanus sean-mcmanus marked this pull request as draft May 1, 2025 23:48
@sean-mcmanus

sean-mcmanus commented May 2, 2025

Copy link
Copy Markdown
Contributor Author

@bobbrow I updated it -- I just noticed they added new strings in the middle of the list instead of only at the end. I've now confirmed that all strings are accounted for (i.e. match).

@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 2, 2025 01:12
@sean-mcmanus sean-mcmanus marked this pull request as draft May 2, 2025 15:58
@sean-mcmanus

sean-mcmanus commented May 2, 2025

Copy link
Copy Markdown
Contributor Author

@bobbrow There's another problem -- if the updated strings (i.e. pre-existing, non-new ones) have different % uses, then it could potentially crash and those strings need to be switched to matching English versions. i.e. I need to review all those...

@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

@bobbrow And we may need to add the English EDG string copies to this GitHub repo for out-of-band translation from VS, not sure yet.

@bobbrow

bobbrow commented May 2, 2025

Copy link
Copy Markdown
Member

@bobbrow There's another problem -- if the updated strings (i.e. pre-existing, non-new ones) have different % uses, then it could potentially crash and those strings need to be switched to matching English versions. i.e. I need to review all those...

ok. Thanks for the extra attention to detail.

@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 2, 2025 20:15
@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

Don't check this in until the FI gets in.

@sean-mcmanus sean-mcmanus merged commit 7e013ab into main May 4, 2025
@sean-mcmanus sean-mcmanus deleted the seanmcm/may1_intellisense_strings branch May 4, 2025 19:50
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.