No error message shown in config UI for invalid compilerPath#13529
Merged
bobbrow merged 1 commit intoApr 17, 2025
mainmicrosoft/vscode-cpptools:mainfrom
bobbrow/compilerPathErrormicrosoft/vscode-cpptools:bobbrow/compilerPathErrorCopy head branch name to clipboard
Merged
No error message shown in config UI for invalid compilerPath#13529bobbrow merged 1 commit intomainmicrosoft/vscode-cpptools:mainfrom bobbrow/compilerPathErrormicrosoft/vscode-cpptools:bobbrow/compilerPathErrorCopy head branch name to clipboard
bobbrow merged 1 commit into
mainmicrosoft/vscode-cpptools:mainfrom
bobbrow/compilerPathErrormicrosoft/vscode-cpptools:bobbrow/compilerPathErrorCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12661
which.syncreturnsnull, notundefinedso invalid paths never had a chance to go through the logic that added the errors.