Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Harden ADO code search endpoint override#327500

Open
sricursion wants to merge 1 commit into
microsoft:mainmicrosoft/vscode:mainfrom
sricursion:codex-fix-ado-code-search-endpointsricursion/vscode:codex-fix-ado-code-search-endpointCopy head branch name to clipboard
Open

Harden ADO code search endpoint override#327500
sricursion wants to merge 1 commit into
microsoft:mainmicrosoft/vscode:mainfrom
sricursion:codex-fix-ado-code-search-endpointsricursion/vscode:codex-fix-ado-code-search-endpointCopy head branch name to clipboard

Conversation

@sricursion

Copy link
Copy Markdown

Fixes #327468

What changed

  • Registers github.copilot.chat.workspace.prototypeAdoCodeSearchEndpointOverride as application-scoped and restricted.
  • Uses the existing userScopeOnly configuration mechanism for the current and migrated legacy keys, so raw workspace and multi-root folder values cannot affect the credential-bearing ADO search request path.
  • Adds regression coverage for workspace, workspace-folder, current user, and legacy user values, plus manifest metadata.

Validation

  • npm run precommit
  • npm run typecheck (Copilot extension)
  • npm run compile (Copilot extension)
  • npm run test:unit -- src/platform/configuration/vscode/test/configurationServiceImpl.spec.ts src/extension/test/node/configurations.spec.ts — 10 passed
  • Targeted ESLint for all changed TypeScript files
  • Full Copilot unit suite with four workers: 9,551 passed; four unrelated tests timed out at 5 seconds in the constrained local runner, and none involved the changed configuration paths.

The extension-wide npm run lint exceeded the local automation's 10-minute command limit without emitting diagnostics; targeted lint completed successfully.

Copilot AI review requested due to automatic review settings July 26, 2026 06:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sricursion
sricursion marked this pull request as ready for review July 26, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADO code-search endpoint override is workspace-scoped while authenticated requests use it

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.