Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't package reference inbox assemblies on .NETCoreApp - #1269

#1269
Merged
AArnott merged 2 commits into
microsoft:mainmicrosoft/vs-threading:mainfrom
ViktorHofer:patch-1ViktorHofer/vs-threading:patch-1Copy head branch name to clipboard
Jan 5, 2024
Merged

Don't package reference inbox assemblies on .NETCoreApp#1269
AArnott merged 2 commits into
microsoft:mainmicrosoft/vs-threading:mainfrom
ViktorHofer:patch-1ViktorHofer/vs-threading:patch-1Copy head branch name to clipboard

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Jan 3, 2024

Copy link
Copy Markdown
Member
  • Microsoft.Win32.Registry got added to the .NETCoreApp shared framework with .NET 5.
  • System.Threading.Tasks.Extensions has been part of the shared framework since I believe .NET Core 2.0.
  • Microsoft.Bcl.AsyncInterfaces since .NET Core 2.1.

Don't reference these packages on .NETCoreApp to reduce the dependency graph and with that potential CVEs / CG warnings.

Microsoft.Win32.Registry got added to the .NETCoreApp shared framework with .NET 5.
System.Threading.Tasks.Extensions has been part of the shared framework since I believe .NET Core 2.0.
Microsoft.Bcl.AsyncInterfaces since .NET Core 2.1.

Don't reference these packages on .NETCoreApp to reduce the dependency graph and with that potential CVEs / CG warnings.
@AArnott

AArnott commented Jan 4, 2024

Copy link
Copy Markdown
Member

@ViktorHofer Is there any reason we should take steps to ensure this goes into 17.9? Or would 17.10 be sufficient?

@ViktorHofer

Copy link
Copy Markdown
Member Author

Responded offline as well. 17.10 is fine, there's no time pressure at all.

@AArnott AArnott added this to the v17.10 milestone Jan 5, 2024
@AArnott
AArnott merged commit f5e95dd into microsoft:main Jan 5, 2024
@ViktorHofer
ViktorHofer deleted the patch-1 branch January 6, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.