Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove PSM from NuGet.config - #7628

#7628
Closed
Youssef1313 wants to merge 1 commit into
mainmicrosoft/testfx:mainfrom
dev/ygerges/psmmicrosoft/testfx:dev/ygerges/psmCopy head branch name to clipboard
Closed

Remove PSM from NuGet.config#7628
Youssef1313 wants to merge 1 commit into
mainmicrosoft/testfx:mainfrom
dev/ygerges/psmmicrosoft/testfx:dev/ygerges/psmCopy head branch name to clipboard

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

dotnet/sdk#52863 broke us. Darc in official pipeline is installed with --add-source but this doesn't work when PSM is used.

SDK PR breaking us dotnet/sdk#52863

See also dotnet/arcade#16628

dotnet/arcade#16642 might fix the failure differently - but I think this might still be good cleanup anyways :)

Copilot AI review requested due to automatic review settings March 30, 2026 10:50
Copilot AI reviewed Mar 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes NuGet Package Source Mapping (PSM) and related configuration from the repo-root NuGet.config to avoid failures introduced by dotnet tool install --add-source behavior changes (impacting Darc installation in official pipelines).

Changes:

  • Removed <packageSourceMapping> so tool installs/restores can honor --add-source.
  • Removed <activePackageSource> and empty dependency-flow-managed comment blocks from NuGet.config.

@Youssef1313

Youssef1313 commented Mar 30, 2026

Copy link
Copy Markdown
Member Author

Looks like we cannot delete PSM:

src\Package\MSTest.Sdk\MSTest.Sdk.csproj(0,0): error NU1507: (NETCORE_ENGINEERING_TELEMETRY=Restore) There are 7 package sources defined in your configuration. When using central package management, please map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: test-tools, dotnet-public, dotnet-tools, dotnet-eng, dotnet9, dotnet10, dotnet11

@Youssef1313 Youssef1313 mentioned this pull request Mar 30, 2026
Merged
@Youssef1313
Youssef1313 deleted the dev/ygerges/psm branch March 30, 2026 10:59
@github-actions github-actions Bot mentioned this pull request Mar 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Youssef1313
Morty Proxy This is a proxified and sanitized view of the page, visit original site.