Add SourceGen + Engine - #4966
#4966Merged
Merged
Conversation
Youssef1313
reviewed
Feb 11, 2025
Youssef1313
left a comment
Member
There was a problem hiding this comment.
Few notes:
-
For MSTest.Engine, we need to keep trimming/AOT warnings enabled as it previously was.
-
I'm not sure about https://github.com/microsoft/testanywhere/blob/807751c35848c8e4ab557c0b39bb2c540e70d96d/Directory.Build.props#L45
Youssef1313
reviewed
Feb 11, 2025
Youssef1313
reviewed
Feb 11, 2025
Member
Author
Fixing
Not needed but thanks for pointing it out |
Youssef1313
approved these changes
Feb 11, 2025
Youssef1313
reviewed
Feb 11, 2025
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.