This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Remove incorrect handling of isninstance#683
Merged
MikhailArkhipov merged 1 commit intoMar 1, 2019
microsoft:mastermicrosoft/python-language-server:masterfrom
MikhailArkhipov:masterCopy head branch name to clipboard
Merged
Remove incorrect handling of isninstance#683MikhailArkhipov merged 1 commit intomicrosoft:mastermicrosoft/python-language-server:masterfrom MikhailArkhipov:masterCopy head branch name to clipboard
MikhailArkhipov merged 1 commit into
microsoft:mastermicrosoft/python-language-server:masterfrom
MikhailArkhipov:masterCopy head branch name to clipboard
Conversation
AlexanderSher
approved these changes
Mar 1, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #668
isinstancehandler which redefinedfbincorrectly. The real fix is Implement tracking variable values by location #682 but it is way more expensive.So the fix is to leave variable type as it is in both cases of the conditional.