Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Port PVA unit tests - #6868

#6868
Merged
tracyboehrer merged 5 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/pva-unit-testsmicrosoft/botbuilder-dotnet:southworks/add/pva-unit-testsCopy head branch name to clipboard
Jan 14, 2025
Merged

Port PVA unit tests#6868
tracyboehrer merged 5 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/pva-unit-testsmicrosoft/botbuilder-dotnet:southworks/add/pva-unit-testsCopy head branch name to clipboard

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

#minor

Description

This PR includes new testing scenarios ported from PVA for the LuParser.

Specific Changes

  • Added new test case ValidLUContentWithComments in LuParserTests class.

Testing

This image shows the new unit tests passing.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Nov 12, 2024
@ceciliaavila
ceciliaavila requested a review from a team as a code owner November 12, 2024 12:55
@tracyboehrer
tracyboehrer merged commit e5a4582 into main Jan 14, 2025
@tracyboehrer
tracyboehrer deleted the southworks/add/pva-unit-tests branch January 14, 2025 15:38
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.