This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6771] Fix Attachment issue when it has a MemoryStream instance - #6850
#6850Merged
tracyboehrer merged 2 commits intoSep 17, 2024
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/attachment-memorystreammicrosoft/botbuilder-dotnet:southworks/fix/attachment-memorystreamCopy head branch name to clipboard
Merged
[#6771] Fix Attachment issue when it has a MemoryStream instance#6850tracyboehrer merged 2 commits intomainmicrosoft/botbuilder-dotnet:mainfrom southworks/fix/attachment-memorystreammicrosoft/botbuilder-dotnet:southworks/fix/attachment-memorystreamCopy head branch name to clipboard
tracyboehrer merged 2 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/attachment-memorystreammicrosoft/botbuilder-dotnet:southworks/fix/attachment-memorystreamCopy head branch name to clipboard
Conversation
tracyboehrer
approved these changes
Sep 17, 2024
Collaborator
Author
|
Im looking at the failing tests |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll |
tracyboehrer
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Fix Attachment issue when it has a MemoryStream instance * Fix unit tests
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6771
Description
This PR fixes an issue with DLASE when a MemoryStream instance is being used as an Activity.Attachment, e.g. a file. The ReadTimeout issue is caused when trying to serialize the non-serializable MemoryStream instance.
Specific Changes
AttachmentMemoryStreamConverterto serialize and deserialize a MemoryStream instance.Testing
The following images show the bot working, and the unit tests passing.
