Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter - #6848

#6848
Merged
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/update/add-cloudadapter-support-in-oauth-exchangemicrosoft/botbuilder-dotnet:southworks/update/add-cloudadapter-support-in-oauth-exchangeCopy head branch name to clipboard
Sep 10, 2024
Merged

[#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter#6848
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/update/add-cloudadapter-support-in-oauth-exchangemicrosoft/botbuilder-dotnet:southworks/update/add-cloudadapter-support-in-oauth-exchangeCopy head branch name to clipboard

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

Fixes #6841

Description

This PR updates the InterceptOAuthCardsAsync method in SkillDialog to support CloudAdapter in combination with expect replies delivery mode.

Specific Changes

  • In InterceptOAuthCardsAsync added a call to UserTokenAccess.ExchangeTokenAsync method, which handles both adapters.

Testing

This image shows the token exchanged for SSO using CloudAdapter and expect replies.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Sep 10, 2024
@ceciliaavila
ceciliaavila requested a review from a team as a code owner September 10, 2024 13:15
@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

@tracyboehrer
tracyboehrer merged commit 1f6ff08 into main Sep 10, 2024
@tracyboehrer
tracyboehrer deleted the southworks/update/add-cloudadapter-support-in-oauth-exchange branch September 10, 2024 13:37
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.