Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

feat: Support Single Tenant authentication through BotFramework-Emulator - #6769

#6769
Merged
tracyboehrer merged 2 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/support-to-singletenant-emulatormicrosoft/botbuilder-dotnet:southworks/add/support-to-singletenant-emulatorCopy head branch name to clipboard
Apr 10, 2024
Merged

feat: Support Single Tenant authentication through BotFramework-Emulator#6769
tracyboehrer merged 2 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/support-to-singletenant-emulatormicrosoft/botbuilder-dotnet:southworks/add/support-to-singletenant-emulatorCopy head branch name to clipboard

Conversation

@JhontSouth

Copy link
Copy Markdown
Collaborator

#minor

Description

This PR includes a dynamic way to validate the access token issuer value depending on the tenant ID used in Emulator.

Specific Changes

  • Added logic to validate the tid and issuer values to allow the Single Tenant authentication in EmulatorValidation.

Testing

The following image shows the Emulator working with a bot using Single Tenant authentication.
image

@JhontSouth
JhontSouth requested a review from a team as a code owner April 4, 2024 15:25
@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Apr 4, 2024
@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 387278

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 78.186%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs 34 30.14%
Totals Coverage Status
Change from base Build 386500: -0.02%
Covered Lines: 26182
Relevant Lines: 33487

💛 - Coveralls

@tracyboehrer
tracyboehrer merged commit ef69173 into main Apr 10, 2024
@tracyboehrer
tracyboehrer deleted the southworks/add/support-to-singletenant-emulator branch April 10, 2024 18:09
jevansaks pushed a commit to jevansaks/botbuilder-dotnet that referenced this pull request May 10, 2024
…tor (microsoft#6769)

* use dynamic Emulator issuer with tenant id to validate identity

* use auth constants
@tracyboehrer

Copy link
Copy Markdown
Member

@JhontSouth This will need to be done in JS too.

@JhontSouth

Copy link
Copy Markdown
Collaborator Author

This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.