Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: cleanup streaming high-perf logs - #6650

#6650
Merged
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
stgum/StreamingLogsmicrosoft/botbuilder-dotnet:stgum/StreamingLogsCopy head branch name to clipboard
Jun 22, 2023
Merged

fix: cleanup streaming high-perf logs#6650
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
stgum/StreamingLogsmicrosoft/botbuilder-dotnet:stgum/StreamingLogsCopy head branch name to clipboard

Conversation

@stevengum

Copy link
Copy Markdown
Member

Fixes #6649

Specific Changes

  • Fixes the high performance logging in the StreamingTransportClient from using the wrong EventId.Name
    • Specifically _clientCompleted and _clientKeepAliveSucceed
  • Adds NamedPipeConnectionStarted and NamedPipeConnectionCompleted for use in CloudAdapter.ConnectNamedPipeAsync() instead of using the incorrect WebSocketConnectionStarted and WebSocketConnectionCompleted.
  • Minor cleanup in logs for StreamingSession and TransportHandler

@stevengum
stevengum requested a review from a team as a code owner June 21, 2023 19:01
@stevengum stevengum added the Automation: No parity PR does not need to be applied to other languages. label Jun 21, 2023
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 356724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 78.979%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 1 77.14%
Totals Coverage Status
Change from base Build 355145: 0.01%
Covered Lines: 25936
Relevant Lines: 32839

💛 - Coveralls

@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

@tracyboehrer
tracyboehrer merged commit 377ea52 into main Jun 22, 2023
@tracyboehrer
tracyboehrer deleted the stgum/StreamingLogs branch June 22, 2023 21:27
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Streaming] High performance logs are incorrect or missing

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.