Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Allow sending GET requests with a body - #6633

#6633
Merged
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/send-get-requests-with-bodymicrosoft/botbuilder-dotnet:southworks/fix/send-get-requests-with-bodyCopy head branch name to clipboard
May 23, 2023
Merged

Allow sending GET requests with a body#6633
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/send-get-requests-with-bodymicrosoft/botbuilder-dotnet:southworks/fix/send-get-requests-with-bodyCopy head branch name to clipboard

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

#minor

Description

This PR allows sending GET requests by adding a body to the request's content.

Composer related issue: #9158.

Specific Changes

  • Modified the switch clause to move the GET request case, to allow the body to be added to the request content.

Testing

The following image shows the GET request sent with a body in the content.
image

@ceciliaavila
ceciliaavila requested a review from a team as a code owner May 18, 2023 19:06
@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label May 18, 2023
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 352201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 78.989%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/HttpRequest.cs 1 87.93%
Totals Coverage Status
Change from base Build 351887: 0.006%
Covered Lines: 25917
Relevant Lines: 32811

💛 - Coveralls

@tracyboehrer
tracyboehrer merged commit 868531d into main May 23, 2023
@tracyboehrer
tracyboehrer deleted the southworks/fix/send-get-requests-with-body branch May 23, 2023 19:58
tracyboehrer pushed a commit that referenced this pull request Nov 6, 2023
Allow send GET requests with body (#6633)
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.