This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#5577] BotFrameworkClientImpl.PostActivityAsync() doesn't support null fromBotId and toBotId values - #6626
#6626Merged
tracyboehrer merged 1 commit intoMay 11, 2023
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/support-null-fromBotId-and-toBotId-valuesmicrosoft/botbuilder-dotnet:southworks/fix/support-null-fromBotId-and-toBotId-valuesCopy head branch name to clipboard
Merged
[#5577] BotFrameworkClientImpl.PostActivityAsync() doesn't support null fromBotId and toBotId values#6626tracyboehrer merged 1 commit intomainmicrosoft/botbuilder-dotnet:mainfrom southworks/fix/support-null-fromBotId-and-toBotId-valuesmicrosoft/botbuilder-dotnet:southworks/fix/support-null-fromBotId-and-toBotId-valuesCopy head branch name to clipboard
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/support-null-fromBotId-and-toBotId-valuesmicrosoft/botbuilder-dotnet:southworks/fix/support-null-fromBotId-and-toBotId-valuesCopy head branch name to clipboard
Conversation
tracyboehrer
approved these changes
May 8, 2023
Collaborator
Pull Request Test Coverage Report for Build 350780
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll |
tracyboehrer
deleted the
southworks/fix/support-null-fromBotId-and-toBotId-values
branch
May 11, 2023 13:13
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5577
Description
This PR updates the PostActivityAsync method in BotFrameworkClientImpl to allow using null values for fromBotId and toBotId arguments. This will avoid failures when anonymous skill bots don't have the AppId property in their settings.
Specific Changes
Testing
The following images show Composer and SDK bots working with anonymous skills.
