Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6596] TeamsChannelData need OnBehalfOf - #6609

#6609
Merged
tracyboehrer merged 5 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/onbehalfof-propertymicrosoft/botbuilder-dotnet:southworks/add/onbehalfof-propertyCopy head branch name to clipboard
Apr 20, 2023
Merged

[#6596] TeamsChannelData need OnBehalfOf#6609
tracyboehrer merged 5 commits into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/onbehalfof-propertymicrosoft/botbuilder-dotnet:southworks/add/onbehalfof-propertyCopy head branch name to clipboard

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

Fixes #6596

Description

This PR adds the OnBehalfOf property to send messages via bots on behalf of another user in Teams.
It also adds unit tests to cover the new code.

Specific Changes

  • Added the OnBehalfOf property in the TeamsChannelData class.
  • Added the TeamsGetTeamOnBehalfOf method to return the current activity's OnBehalfOf list.

Testing

The following image shows the message of the bot on behalf of another user in the Teams channel.
image

The following image shows the related unit test passing.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Mar 28, 2023
@ceciliaavila
ceciliaavila requested a review from a team as a code owner March 28, 2023 15:34
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 345844

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.008%) to 79.096%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Streaming/Transport/NamedPipe/NamedPipeClient.cs 1 71.43%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityExtensions.cs 4 78.26%
Totals Coverage Status
Change from base Build 344537: -0.008%
Covered Lines: 25817
Relevant Lines: 32640

💛 - Coveralls

@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@tracyboehrer
tracyboehrer merged commit e609c2c into main Apr 20, 2023
@tracyboehrer
tracyboehrer deleted the southworks/add/onbehalfof-property branch April 20, 2023 13:25
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TeamsChannelData need OnBehalfOf

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.