Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language - #6554

#6554
Merged
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/prompt-recognize-languagemicrosoft/botbuilder-dotnet:southworks/add/prompt-recognize-languageCopy head branch name to clipboard
Nov 18, 2022
Merged

[#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language#6554
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/add/prompt-recognize-languagemicrosoft/botbuilder-dotnet:southworks/add/prompt-recognize-languageCopy head branch name to clipboard

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

Fixes #6531

Description

This PR adds the new RecognizeLanguage property in the PromptOptions class to be used in the onRecognizedAsync method allowing a different language than the one determined by the activity.
It also updates the onRecognizedAsync method of the ConfirmPrompt class to use this property solving the issue when a ConfirmPrompt is used along with a TranslationMiddleware.

Specific Changes

  • Updated PromptOptions class adding the RecognizeLanguage property.
  • Updated the onRecognizedAsync method of the ConfirmPrompt class using the new property.
  • Added a unit test in ConfirmPromptTests to cover the new test case.

Testing

These images show a bot using the translator service and the confirm prompt working as expected.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Nov 17, 2022
@ceciliaavila
ceciliaavila requested a review from a team as a code owner November 17, 2022 17:33
@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

@tracyboehrer
tracyboehrer merged commit 55eb4f1 into main Nov 18, 2022
@tracyboehrer
tracyboehrer deleted the southworks/add/prompt-recognize-language branch November 18, 2022 18:21
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prompt validation of confirm prompt in chatbot is not working for newly added language

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.