Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix CodeQL alert SM03926: Security sensitive JsonWebTokenHandler validations are disabled #6550

Merged
tracyboehrer merged 1 commit into from
Nov 14, 2022
Merged

Fix CodeQL alert SM03926: Security sensitive JsonWebTokenHandler validations are disabled #6550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 libraries/Microsoft.Bot.Connector/Authentication/ChannelValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static class ChannelValidation
ValidIssuers = new[] { AuthenticationConstants.ToBotFromChannelTokenIssuer },

// Audience validation takes place in JwtTokenExtractor
ValidateAudience = false,
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true,
Expand Down
4 changes: 3 additions & 1 deletion 4 libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ public static class EmulatorValidation
"https://login.microsoftonline.us/f8cdef31-a31e-4b4a-93e4-5f571e91255a/", // Auth for US Gov, 1.0 token
"https://login.microsoftonline.us/f8cdef31-a31e-4b4a-93e4-5f571e91255a/v2.0", // Auth for US Gov, 2.0 token
},
ValidateAudience = false, // Audience validation takes place manually in code.

// Audience validation takes place manually in code.
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true,
Expand Down
2 changes: 1 addition & 1 deletion 2 libraries/Microsoft.Bot.Connector/Authentication/EnterpriseChannelValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public sealed class EnterpriseChannelValidation
ValidIssuers = new[] { AuthenticationConstants.ToBotFromChannelTokenIssuer },

// Audience validation takes place in JwtTokenExtractor
ValidateAudience = false,
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true,
Expand Down
2 changes: 1 addition & 1 deletion 2 libraries/Microsoft.Bot.Connector/Authentication/GovernmentChannelValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public sealed class GovernmentChannelValidation
ValidIssuers = new[] { GovernmentAuthenticationConstants.ToBotFromChannelTokenIssuer },

// Audience validation takes place in JwtTokenExtractor
ValidateAudience = false,
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true,
Expand Down
6 changes: 4 additions & 2 deletions 6 libraries/Microsoft.Bot.Connector/Authentication/ParameterizedBotFrameworkAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ private async Task<ClaimsIdentity> SkillValidation_AuthenticateChannelTokenAsync
"https://sts.windows.net/cab8a31a-1906-4287-a0d8-4eef66b95f6e/", // Auth for US Gov, 1.0 token
"https://login.microsoftonline.us/cab8a31a-1906-4287-a0d8-4eef66b95f6e/v2.0" // Auth for US Gov, 2.0 token
},
ValidateAudience = false, // Audience validation takes place manually in code.

// Audience validation takes place manually in code.
ValidateAudience = true, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true
Expand Down Expand Up @@ -406,7 +408,7 @@ private TokenValidationParameters GovernmentChannelValidation_GetTokenValidation
ValidIssuers = new[] { _toBotFromChannelTokenIssuer },

// Audience validation takes place in JwtTokenExtractor
ValidateAudience = false,
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true,
Expand Down
4 changes: 3 additions & 1 deletion 4 libraries/Microsoft.Bot.Connector/Authentication/SkillValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ public static async Task<ClaimsIdentity> AuthenticateChannelToken(string authHea
"https://login.microsoftonline.us/f8cdef31-a31e-4b4a-93e4-5f571e91255a/", // Auth for US Gov, 1.0 token
"https://login.microsoftonline.us/f8cdef31-a31e-4b4a-93e4-5f571e91255a/v2.0", // Auth for US Gov, 2.0 token
},
ValidateAudience = false, // Audience validation takes place manually in code.

// Audience validation takes place manually in code.
ValidateAudience = false, // lgtm[cs/web/missing-token-validation]
ValidateLifetime = true,
ClockSkew = TimeSpan.FromMinutes(5),
RequireSignedTokens = true
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.