This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Fix CodeQL alert SM01507: Client-side URL redirect - #6538
#6538Merged
tracyboehrer merged 1 commit intoNov 3, 2022
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/SM01507-alertmicrosoft/botbuilder-dotnet:southworks/fix/SM01507-alertCopy head branch name to clipboard
Merged
Fix CodeQL alert SM01507: Client-side URL redirect#6538tracyboehrer merged 1 commit intomainmicrosoft/botbuilder-dotnet:mainfrom southworks/fix/SM01507-alertmicrosoft/botbuilder-dotnet:southworks/fix/SM01507-alertCopy head branch name to clipboard
tracyboehrer merged 1 commit into
mainmicrosoft/botbuilder-dotnet:mainfrom
southworks/fix/SM01507-alertmicrosoft/botbuilder-dotnet:southworks/fix/SM01507-alertCopy head branch name to clipboard
Conversation
This was
linked to
issues
Nov 3, 2022
Collaborator
Pull Request Test Coverage Report for Build 327818
💛 - Coveralls |
tracyboehrer
approved these changes
Nov 3, 2022
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6537 #6521 #6514 #6500 #6499 #6498 #6497 #6496 #6495 #6494 #6493 #6492 #6491 #6490 #6489 #6488 #6486
Description
This PR fixes de CodeQL SM01507 alert related to open redirects by implementing a fixed domain for the script's src param.
Specific Changes
build/AnalyzeDeps/InterdependencyGraph.htmlto append the domain URL to the data param.Testing
We tested the changes locally rendering the HTML with and without the data query parameter.
