Features/locale aware header links#1222
Open
takashiuesaka wants to merge 2 commits into
microsoft:mainmicrosoft/aspire.dev:mainfrom
takashiuesaka:Features/locale-aware-header-linkstakashiuesaka/aspire.dev:Features/locale-aware-header-linksCopy head branch name to clipboard
Open
Features/locale aware header links#1222takashiuesaka wants to merge 2 commits intomicrosoft:mainmicrosoft/aspire.dev:mainfrom takashiuesaka:Features/locale-aware-header-linkstakashiuesaka/aspire.dev:Features/locale-aware-header-linksCopy head branch name to clipboard
takashiuesaka wants to merge 2 commits into
microsoft:mainmicrosoft/aspire.dev:mainfrom
takashiuesaka:Features/locale-aware-header-linkstakashiuesaka/aspire.dev:Features/locale-aware-header-linksCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds locale-aware routing for the “Docs” and “Try Aspire” header links so they resolve to the correct localized paths.
Changes:
- Introduced
addLocaleToPathusage in the header component. - Derived
localefromAstro.locals.starlightRoute?.localeand generated localized URLs. - Updated desktop and mobile header anchors to use the computed localized URLs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1220