Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[release/9.3] branding for 9.3.1 - #9539

#9539
Merged
joperezr merged 2 commits into
microsoft:release/9.3microsoft/aspire:release/9.3from
danmoseley:branding931danmoseley/aspire:branding931Copy head branch name to clipboard
May 29, 2025
Merged

[release/9.3] branding for 9.3.1#9539
joperezr merged 2 commits into
microsoft:release/9.3microsoft/aspire:release/9.3from
danmoseley:branding931danmoseley/aspire:branding931Copy head branch name to clipboard

Conversation

@danmoseley

@danmoseley danmoseley commented May 28, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@danmoseley
danmoseley requested review from Copilot and joperezr May 28, 2025 00:13
Copilot AI reviewed May 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version information for the upcoming 9.3.1 branding.

  • Bumps the PatchVersion from 0 to 1.
Comments suppressed due to low confidence (1)

eng/Versions.props:8

  • Please verify if the pre-release version label 'preview.1' is intended for this release; consider updating or removing it if this is a final release.
<PreReleaseVersionLabel>preview.1</PreReleaseVersionLabel>

@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 28, 2025
@danmoseley danmoseley changed the title branding for 9.3.1 [release/9.3] branding for 9.3.1 May 28, 2025
@danmoseley danmoseley added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels May 28, 2025
@danmoseley

danmoseley commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Please verify if the pre-release version label 'preview.1' is intended for this release; consider updating or removing it if this is a final release.

@joperezr I assume this is fine because 9.2.1 shipped that way.

@danmoseley
danmoseley requested a review from wtgodbe May 28, 2025 00:18
wtgodbe
wtgodbe approved these changes May 28, 2025
View reviewed changes

@wtgodbe wtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, do we know why the extensions package isn't in the feed?

@danmoseley

danmoseley commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

It's because release/9.3 has

    <packageSource key="dotnet-extensions">
      <package pattern="Microsoft.Extensions.AI*" />
    </packageSource>

and main doesn't. This was f76a033

@joperezr what's the correct resolution of this... take the above out of nuget.config?

@joperezr

joperezr commented May 28, 2025

Copy link
Copy Markdown
Member

@joperezr what's the correct resolution of this... take the above out of nuget.config?

Yeah, we should remove that, and I believe there are some other changes that we'll need to do here to get a green build. If you want me to, I'm happy to take this over and push some changes later today to fix.

@danmoseley

danmoseley commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Sure go ahead

@joperezr
joperezr requested review from eerhardt and radical as code owners May 29, 2025 19:13
@joperezr
joperezr merged commit 8b51817 into microsoft:release/9.3 May 29, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments
@joperezr joperezr joperezr approved these changes
@radical radical Awaiting requested review from radical radical is a code owner
@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner
+1 more reviewer
@wtgodbe wtgodbe wtgodbe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@joperezr joperezr

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danmoseley @joperezr @wtgodbe
Morty Proxy This is a proxified and sanitized view of the page, visit original site.