Merged
Fully qualify OutputPath for PublishingContext#9351
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the PublishingContext consistently receives a fully qualified OutputPath, addressing an issue where relative paths might cause unexpected behavior. The changes include adding an assertion in tests to verify the fully qualified path and updating the Publisher to use Path.GetFullPath.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/PublishingTests.cs | Adds an assertion to check that OutputPath is fully qualified in the test. |
| src/Aspire.Hosting/Publishing/Publisher.cs | Updates the PublishingContext initialization to use a fully qualified path. |
davidfowl
reviewed
May 16, 2025
| } | ||
|
|
||
| var context = new PublishingContext(model, executionContext, serviceProvider, logger, cancellationToken, options.Value.OutputPath); | ||
| var context = new PublishingContext(model, executionContext, serviceProvider, logger, cancellationToken, Path.GetFullPath(options.Value.OutputPath)); |
Contributor
There was a problem hiding this comment.
Hmm, relative to what? CWD? I think this is right.
Contributor
Author
There was a problem hiding this comment.
Yep -- it uses CWD as the base AFAIK. I'll remember to update the tests to check for this as a tack on to a future PR.
davidfowl
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9346.