Test that ensures legacy dashboard token env var is honored - #9296
#9296Merged
DamianEdwards merged 1 commit intoMay 14, 2025
mainmicrosoft/aspire:mainfrom
damianedwards/test-legacy-dashboard-env-varsmicrosoft/aspire:damianedwards/test-legacy-dashboard-env-varsCopy head branch name to clipboard
Merged
Test that ensures legacy dashboard token env var is honored#9296DamianEdwards merged 1 commit intomainmicrosoft/aspire:mainfrom damianedwards/test-legacy-dashboard-env-varsmicrosoft/aspire:damianedwards/test-legacy-dashboard-env-varsCopy head branch name to clipboard
DamianEdwards merged 1 commit into
mainmicrosoft/aspire:mainfrom
damianedwards/test-legacy-dashboard-env-varsmicrosoft/aspire:damianedwards/test-legacy-dashboard-env-varsCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds legacy environment variable coverage for the dashboard token in an existing test, ensuring backward compatibility.
- Converts a single-case test (
[Fact]) into a parameterized one ([Theory]) to run with both current and legacy token env var names - Adds
InlineDataforKnownConfigNames.Legacy.DashboardFrontendBrowserToken - Updates the test logic to use the
tokenEnvVarNameparameter instead of a hardcoded config name
Comments suppressed due to low confidence (1)
tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs:653
- [nitpick] Consider renaming the test method to reflect that it now covers both current and legacy token env vars, e.g.,
StartAsync_DashboardAuthConfig_HonorsCurrentAndLegacyTokenEnvVars.
[Theory]
JamesNK
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates a test to ensure the dashboard honors the legacy environment variable for the dashboard token.
Fixes #8487