Conversation
7d0c9c2 to
c0d5f4c
Compare
a280eea to
f1e17ab
Compare
f1e17ab to
9c201c5
Compare
cbed789 to
3752e74
Compare
6fe8795 to
a837a27
Compare
9f37c81 to
4c75793
Compare
0dac5eb to
139f642
Compare
| public static ApplicationModel.IResourceBuilder<AzureUserAssignedIdentityResource> AddAzureUserAssignedIdentity(this IDistributedApplicationBuilder builder, string name) { throw null; } | ||
| } | ||
|
|
||
| public sealed partial class AzureUserAssignedIdentityResource : AzureProvisioningResource, IAppIdentityResource |
There was a problem hiding this comment.
Should it be named AzureUserAssignedManagedIdentityResource?
There was a problem hiding this comment.
Azure.Provisioning calls it UserAssignedIdentity, so I don't think "Managed" is necessary.
FYI - @tg-msft
|
FWIW, since we talked about it yesterday, I have validated that all brand new packages/integrations we are adding this release are set to stay in preview. FYI: @DamianEdwards since you were asking about this. |
139f642 to
d4dfe99
Compare
60be407 to
9c78d1c
Compare
|
anything left here or can we close this now? |
|
Let me rerun real quick against release branch to ensure the shape matches what we have in release/9.3 as opposed to main in case we have new apis in main already. After that I'll merge this in |
FYI - [release/9.3] Respond to API Review feedback (dotnet/aspire#9285) was only in the release branch. I didn't make a PR for main, with the thinking that the release branch will merge back to main. So you will see that diff. |
9c78d1c to
7b7eadb
Compare
|
Ok commit is pushed. @eerhardt can you confirm that this is showing what you expect that will be released in 9.3? |
|
Doing a quick spot check it does seem like the changes are captured as expected. |
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.