Mitchdenny/wait-behavior-follow-up - #7668
#7668Merged
mitchdenny merged 3 commits intoFeb 19, 2025
mainmicrosoft/aspire:mainfrom
mitchdenny/wait-behavior-follow-upmicrosoft/aspire:mitchdenny/wait-behavior-follow-upCopy head branch name to clipboard
Merged
Mitchdenny/wait-behavior-follow-up#7668mitchdenny merged 3 commits intomainmicrosoft/aspire:mainfrom mitchdenny/wait-behavior-follow-upmicrosoft/aspire:mitchdenny/wait-behavior-follow-upCopy head branch name to clipboard
mitchdenny merged 3 commits into
mainmicrosoft/aspire:mainfrom
mitchdenny/wait-behavior-follow-upmicrosoft/aspire:mitchdenny/wait-behavior-follow-upCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Aspire.Hosting/ResourceBuilderExtensions.cs:741
- Renamed WaitBehavior enumeration values to StopOnResourceUnavailable and WaitOnResourceUnavailable.
WaitFor(messaging, WaitBehavior.StopOnResourceUnavailable);
eerhardt
approved these changes
Feb 19, 2025
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks good. Just 2 comments on comments
Member
Author
|
/backport to release/9.1 |
Contributor
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13403420214 |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #7650. Renames WaitBehavior enumeration values and adopts Davids ShouldYield inner method.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):