Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add WithParentRelationship overload accepting an IResourceBuilder - #7615

#7615
Merged
eerhardt merged 1 commit into
microsoft:mainmicrosoft/aspire:mainfrom
eerhardt:AddWithParentBuildereerhardt/aspire:AddWithParentBuilderCopy head branch name to clipboard
Feb 14, 2025
Merged

Add WithParentRelationship overload accepting an IResourceBuilder#7615
eerhardt merged 1 commit into
microsoft:mainmicrosoft/aspire:mainfrom
eerhardt:AddWithParentBuildereerhardt/aspire:AddWithParentBuilderCopy head branch name to clipboard

Conversation

@eerhardt

Copy link
Copy Markdown
Member

Description

Fix #7594

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • [x ] No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs: Evaluated as low risk
  • tests/Aspire.Hosting.Tests/Orchestrator/RelationshipEvaluatorTests.cs: Evaluated as low risk

@eerhardt
eerhardt merged commit 6e2746b into microsoft:main Feb 14, 2025
@eerhardt

Copy link
Copy Markdown
Member Author

/backport to release/9.1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13333782294

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow passing parent to WithParentRelationship as IResourceBuilder<T>

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.