Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't display telemetry actions when no telemetry - #6568

#6568
Merged
JamesNK merged 1 commit into
mainmicrosoft/aspire:mainfrom
jamesnk/hide-telemetry-actionsmicrosoft/aspire:jamesnk/hide-telemetry-actionsCopy head branch name to clipboard
Oct 31, 2024
Merged

Don't display telemetry actions when no telemetry#6568
JamesNK merged 1 commit into
mainmicrosoft/aspire:mainfrom
jamesnk/hide-telemetry-actionsmicrosoft/aspire:jamesnk/hide-telemetry-actionsCopy head branch name to clipboard

Conversation

@JamesNK

@JamesNK JamesNK commented Oct 31, 2024

Copy link
Copy Markdown
Member

Description

Before: If a resource doesn't have telemetry then display disabled telemetry menu items
After: If a resource doesn't have telemetry then don't display telemetry menu items

telemetry-menu-items

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK
JamesNK enabled auto-merge (squash) October 31, 2024 06:06
@JamesNK

JamesNK commented Oct 31, 2024

Copy link
Copy Markdown
Member Author

/backport to release/9.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11607051830

@JamesNK
JamesNK merged commit 34d6aab into main Oct 31, 2024
@JamesNK
JamesNK deleted the jamesnk/hide-telemetry-actions branch October 31, 2024 06:35
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.