Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add tooltip to error logs link - #6546

#6546
Merged
davidfowl merged 2 commits into
mainmicrosoft/aspire:mainfrom
jamesnk/error-logs-link-tooltipmicrosoft/aspire:jamesnk/error-logs-link-tooltipCopy head branch name to clipboard
Oct 30, 2024
Merged

Add tooltip to error logs link#6546
davidfowl merged 2 commits into
mainmicrosoft/aspire:mainfrom
jamesnk/error-logs-link-tooltipmicrosoft/aspire:jamesnk/error-logs-link-tooltipCopy head branch name to clipboard

Conversation

@JamesNK

@JamesNK JamesNK commented Oct 29, 2024 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Description

Fixes #6512

After:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@davidfowl

davidfowl commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Tried this in a codespace and I see this:

image

@JamesNK

JamesNK commented Oct 30, 2024

Copy link
Copy Markdown
Member Author

Fixed. There was an existing issue with displaying text when there was one error.

@build-analysis build-analysis Bot mentioned this pull request Oct 30, 2024
Closed
davidfowl
davidfowl approved these changes Oct 30, 2024
View reviewed changes

@davidfowl davidfowl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

@davidfowl
davidfowl merged commit 13bcaa0 into main Oct 30, 2024
@davidfowl
davidfowl deleted the jamesnk/error-logs-link-tooltip branch October 30, 2024 14:26
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes
@drewnoakes drewnoakes Awaiting requested review from drewnoakes
@adamint adamint Awaiting requested review from adamint adamint is a code owner

Assignees

No one assigned

Labels

area-dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hovering over the error icon in the resources view shows the status as the tooltip

2 participants

@JamesNK @davidfowl
Morty Proxy This is a proxified and sanitized view of the page, visit original site.