Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't pass meter descriptions as units - #6448

#6448
Merged
JamesNK merged 2 commits into
microsoft:mainmicrosoft/aspire:mainfrom
gansb:maingansb/aspire:mainCopy head branch name to clipboard
Oct 24, 2024
Merged

Don't pass meter descriptions as units#6448
JamesNK merged 2 commits into
microsoft:mainmicrosoft/aspire:mainfrom
gansb:maingansb/aspire:mainCopy head branch name to clipboard

Conversation

@gansb

@gansb gansb commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Description

When publishing as prometheus metrics the kafka gauge metrics are exported as

# TYPE messaging_kafka_consumer_queue_message_count_Number of ops (callbacks, events, etc) waiting in queue for application to serve with rd_kafka_poll() gauge
# UNIT messaging_kafka_consumer_queue_message_count_Number of ops (callbacks, events, etc) waiting in queue for application to serve with rd_kafka_poll() Number of ops (callbacks, events, etc) waiting in queue for application to serve with rd_kafka_poll()
messaging_kafka_consumer_queue_message_count_Number of ops (callbacks, events, etc) waiting in queue for application to serve with rd_kafka_poll()

This may be because the description is passed as a unit.

Fixes #6447

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Oct 23, 2024
@gansb gansb changed the title Don't pass the gauge description as a unit Don't pass meter descriptions as units Oct 23, 2024
@gansb

gansb commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@mitchdenny

Copy link
Copy Markdown
Member

@samsp-msft @JamesNK

@JamesNK

JamesNK commented Oct 23, 2024

Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a test. Can be done as a follow up.

@davidfowl

Copy link
Copy Markdown
Contributor

Does this need to be backported?

@JamesNK
JamesNK merged commit c3cdb10 into microsoft:main Oct 24, 2024
@JamesNK

JamesNK commented Oct 24, 2024

Copy link
Copy Markdown
Member

@gansb Thanks for the fix!

@eerhardt Can you manage getting this backported to 9.0?

@davidfowl

Copy link
Copy Markdown
Contributor

/backport to release/9.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11492020195

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 23, 2024
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aspire.Confluent.Kafka publishes broken metrics

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.